Skip to content

[Bugfix] Fix entrypoints metrics tests #18063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

[Bugfix] Fix entrypoints metrics tests #18063

merged 1 commit into from
May 13, 2025

Conversation

DarkLight1337
Copy link
Member

Fix a failing test introduced by #17935. Turns out it's not a transient issue

@DarkLight1337 DarkLight1337 requested a review from Isotr0py May 13, 2025 09:53
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 13, 2025
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

DarkLight1337
DarkLight1337 commented May 13, 2025
View reviewed changes
vllm/entrypoints/openai/api_server.py
Comment on lines +189 to +190
# Don't keep the dummy data in memory
await async_llm.reset_mm_cache()
Copy link
Member Author

@DarkLight1337 DarkLight1337 May 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, calling reset_mm_cache in V0 causes vllm:iteration_tokens_total_count metric to be offset by one. Since there is no need to sync the caches in V0, I simply removed the reset_mm_cache call from the top level since it's called inside V0 LLMEngine (which is inherited by _AsyncLLMEngine) anyway.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 13, 2025 10:15
@vllm-bot vllm-bot merged commit b922c2e into vllm-project:main May 13, 2025
62 of 64 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-metrics-tests branch May 13, 2025 13:43
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@DarkLight1337
[Bugfix] Fix entrypoints metrics tests (vllm-project#18063)
58beb66 
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @Isotr0py @vllm-bot